Fix return in finally block silently suppressing exceptions#1763
Open
Otman404 wants to merge 2 commits intounclecode:mainfrom
Open
Fix return in finally block silently suppressing exceptions#1763Otman404 wants to merge 2 commits intounclecode:mainfrom
Otman404 wants to merge 2 commits intounclecode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
return resultsout of thefinallyblock inMemoryAdaptiveDispatcher.run_urlssince it was silently suppressing any exception propagating from thetryorexceptblocksList of files changed and why
crawl4ai/async_dispatcher.py- Movedreturn resultsfrom inside thefinallyblock to after it inMemoryAdaptiveDispatcher.run_urlsbefore
after
before
after
How Has This Been Tested?
9/10 existing tests pass. The one failure (
test_monitor_integration)Checklist: