fix(ui): color picker dropdown closing and custom color memory#4863
fix(ui): color picker dropdown closing and custom color memory#4863LeoGradual wants to merge 1 commit intoudecode:mainfrom
Conversation
- Keep dropdown open during native color picker input (modal mode) - Remember custom colors across open/close cycles via session queue - Scan editor marks to populate used colors on open - Fix + button overlapping color circles (grid placement) - Contrast-aware check icon for selected color on dark backgrounds Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
dosubot
bot
added
size:L
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9824b618e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (targetColor: string) => | ||
| colors.some( | ||
| (c) => normalizeColor(c.value) === normalizeColor(targetColor) | ||
| ) || | ||
| fullCustomColors.some( |
There was a problem hiding this comment.
isColorInCollections only checks colors and fullCustomColors, so a value that already exists in customColors (the predefined custom row) is treated as a brand-new color. When that happens (for example, selecting the same hex via the native color input), updatedColor gets rendered again as customColor, creating a duplicate swatch and consuming one history slot unnecessarily. Add customColors to this membership check so existing custom entries are not duplicated.
Useful? React with 👍 / 👎.
2 participants
Summary
col-start-10)Test plan
🤖 Generated with Claude Code