liblightdm-gobject: define common-user GIR type - #464
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
The internal property generated an unnamed GIR type, so annotate its concrete type and guard generated GIR metadata in make check. Generated by Ora Studio Vibe coded by ousama Co-Authored-By: Ora Agent <noreply@oratelecom.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common-userproperty with its concrete introspection type<type>elements whenxmllintis availablexmllintat configure time and distinguish inspection errors from malformed type metadataTest verification (RED → GREEN)
RED check (same check with the production annotation removed): 1/1 new checks failed:
GREEN check (same check with the annotation restored): 1/1 new checks passed:
pinned downstream parser reproduction: gtk-rs
girat2ae5101reportsMissing name attribute on <type> elementbefore the fix and no error after itfull local suite, Ubuntu rolling: 352/352 passed
full local suite, Fedora latest: 352/352 passed
Fixes #463
Generated by Ora Studio
Vibe coded by ousama