Skip to content

liblightdm-gobject: define common-user GIR type - #464

Open
ousamabenyounes wants to merge 1 commit into
ubuntu:mainfrom
ousamabenyounes:fix/issue-463
Open

liblightdm-gobject: define common-user GIR type#464
ousamabenyounes wants to merge 1 commit into
ubuntu:mainfrom
ousamabenyounes:fix/issue-463

Conversation

@ousamabenyounes

Copy link
Copy Markdown

Summary

  • annotate the internal common-user property with its concrete introspection type
  • reject generated GIR files that contain unnamed <type> elements when xmllint is available
  • detect xmllint at configure time and distinguish inspection errors from malformed type metadata

Test verification (RED → GREEN)

  • RED check (same check with the production annotation removed): 1/1 new checks failed:

    $ make check DEBUG=true
    LightDM-1.gir contains an unnamed type
    make[2]: *** [Makefile:1039: check-local] Error 1
    
  • GREEN check (same check with the annotation restored): 1/1 new checks passed:

    $ make check DEBUG=true
    Testsuite summary for lightdm 1.33.1
    # TOTAL: 352
    # PASS:  352
    # FAIL:  0
    # ERROR: 0
    
  • pinned downstream parser reproduction: gtk-rs gir at 2ae5101 reports Missing name attribute on <type> element before the fix and no error after it

  • full local suite, Ubuntu rolling: 352/352 passed

  • full local suite, Fedora latest: 352/352 passed

Fixes #463

Generated by Ora Studio
Vibe coded by ousama

The internal property generated an unnamed GIR type, so annotate its concrete type and guard generated GIR metadata in make check.

Generated by Ora Studio
Vibe coded by ousama

Co-Authored-By: Ora Agent <noreply@oratelecom.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

liblightdm-gobject gir: "common-user" property missing name attribute in <type>

1 participant