Skip to content

Remove debian/ folder - #457

Merged
JPeisach merged 1 commit into
ubuntu:mainfrom
JPeisach:rem-debian
Aug 12, 2026
Merged

Remove debian/ folder#457
JPeisach merged 1 commit into
ubuntu:mainfrom
JPeisach:rem-debian

Conversation

@JPeisach

@JPeisach JPeisach commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

This allows for the project to be distro neutral, and prevents redundancy.

Closes #456


Just need to check to make sure any important files aren't being removed, then probably going to leave it open for another day in case of any objections.

Reference package sources:
Fedora Rawhide - https://src.fedoraproject.org/rpms/lightdm/tree/rawhide
Debian - https://salsa.debian.org/xfce-extras-team/lightdm/-/tree/debian/master/debian
Arch - https://gitlab.archlinux.org/archlinux/packaging/packages/lightdm

This allows for the project to be distro neutral, and prevents
redundancy.

Closes ubuntu#456

Signed-off-by: Joshua Peisach <jpeisach@ubuntu.com>
Comment thread debian/50-disable-guest.conf
Comment thread debian/patches/04_language_handling.patch
@@ -1,22 +0,0 @@
Description: Workaround faulty setting from Ubuntu user-setup package
Author: Robert Ancell <robert.ancell@canonical.com>
Bug: https://bugs.launchpad.net/bugs/1484083

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be sent upstream?

Comment thread debian/lightdm.service
@@ -1,17 +0,0 @@
[Unit]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should sample service files be shipped upstream?

@Franklin-Qi

Copy link
Copy Markdown

The overall direction of this PR looks right to me: removing the in-tree debian/ directory keeps LightDM upstream distro-neutral.
Before merge, I’d suggest adding two clarifications:

  1. explicitly state that the removed files are Debian/Ubuntu packaging assets only and do not affect upstream runtime code, tests, or core guest-session logic;
  2. if any patch under debian/patches still has upstream value, track it in a separate issue/PR instead of letting it disappear implicitly with this directory removal.

Also, please note that this overlaps with PRs still touching debian/ (for example #369), so those follow-up branches will need rebasing or cleanup.

@JPeisach
JPeisach merged commit 0dd74ae into ubuntu:main Aug 12, 2026
2 checks passed
@JPeisach

Copy link
Copy Markdown
Collaborator Author

#458 will track removed packaging defaults

@JPeisach JPeisach modified the milestones: 1.34.0, 1.33.1 Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep debian/ folder?

2 participants