refactor(orchestrator): route metrics through observability/metrics Emitter#216
Open
xytan0056 wants to merge 2 commits into
Open
refactor(orchestrator): route metrics through observability/metrics Emitter#216xytan0056 wants to merge 2 commits into
xytan0056 wants to merge 2 commits into
Conversation
xytan0056
force-pushed
the
pr3-orchestrator-metrics
branch
3 times, most recently
from
July 17, 2026 21:47
3b9c7e9 to
97b3839
Compare
…tter Port the controller off tally.Scope to *metrics.Emitter using the Begin/Complete lifecycle helper per docs/observability/metrics.md. - Params.Scope tally.Scope -> Emitter *metrics.Emitter (optional, nil->Nop) - Each RPC bakes the repo tag into a per-request emitter, then Begin/Complete emit start + result-tagged finish (replacing calls/success/failure and the total_duration timers); no domain metrics struct or memoization - Sub-operations (get_graph, compare_target_graphs) get their own Begin/Complete lifecycle; compare_target_graphs flattens to its own op - Custom timers -> DurationHistogram on the repo-tagged emitter with explicit package-level buckets (controller/metrics.go) - emitFailureMetric(e, op, err) keeps the failure_type/reason axis - Add controller/metrics_test.go asserting the start/finish path shape
…mitter Port native_orchestrator's GetTargetGraph metrics off raw tally.Scope to the Begin/Complete lifecycle helper. - Params keeps Scope tally.Scope; the orchestrator self-subscopes to "orchestrator" and builds its own emitter (still forwards the scope to the graph runner). - start + result-tagged finish (replaces calls/success/failure); recordFailure keeps the failure_type/failure_reason axis as a "failures" counter. - Buckets are package-level in orchestrator/metrics.go.
xytan0056
force-pushed
the
pr2-controller-metrics
branch
from
July 17, 2026 23:10
d62bb17 to
7a8d276
Compare
xytan0056
force-pushed
the
pr3-orchestrator-metrics
branch
from
July 17, 2026 23:10
97b3839 to
57d3c09
Compare
xytan0056
changed the title
xytan0056
force-pushed
the
pr2-controller-metrics
branch
from
July 21, 2026 06:30
7a8d276 to
e77a1cb
Compare
xytan0056
commented
Jul 21, 2026
| return nil, fmt.Errorf("no repository configuration found for remote %q", remote) | ||
| } | ||
| leaseStart := time.Now() | ||
| ws, err := b.repoManager.Lease(ctx, build) |
Contributor
Author
There was a problem hiding this comment.
TODO: emit metrics before Lease error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
native_orchestrator'sGetTargetGraphoff rawtally.Scopeto*metrics.Emitterwith theBegin/Completehelper.ParamskeepsScope tally.Scope; the orchestrator self-subscopes toorchestratorand builds its own emitter (still forwards the scope to the graph runner).start+ result-taggedfinish(replacescalls/success/failure).get_target_graph:lease_duration,checkout_duration,apply_requests_duration,cache_read_duration,compute_duration,cache_write_duration.Stacked on #215.