Repository navigation
fix(detection): honor config concurrency when --concurrent is omitted - #207
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
main_benchmark.py gave --concurrent a default of 10 and always wrote it into the config, so concurrency.max_concurrent_tasks in config_benchmark.yaml was never used. Default the flag to None and only override the config when the flag is passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Default the flag to None and only override the config when it is passed (same pattern main_detector.py uses for its
--concurrent).Why?
Main_benchmark.py main() declares
--concurrentwithdefault=10and always callsconfig.update_concurrent_tasks(args.concurrent)(main_benchmark.py:1333,1342), soconcurrency.max_concurrent_tasksin config_benchmark.yaml is never used. Setting it to 3 and runningpython main_benchmark.pystill runs 10 tasks at once.How did you test it?
TestMainConcurrencyin tests/test_main_benchmark.py (config file with max_concurrent_tasks: 3, BenchmarkRunner stubbed). main:test_config_concurrency_used_without_flagfailsassert 10 == 3; branch: both pass.pytest tests/ -q-> 258 passed (main 256 + 2 new).concurrencysection now falls back to Config.max_concurrent_tasks's default (3) instead of the old hard-coded 10.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.
AI assistance: Claude Code (model Claude Opus 5.5) found this bug, wrote the fix and test, and drafted this description; submitted by @rudycelekli.
🤖 Generated with Claude Code