Repository navigation
fix(discovery): read JSON-with-comments config files - #206
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
VS Code's mcp.json and Zed's settings.json are JSONC, and format_for already routes `.jsonc` to the JSON parser, but parse() used strict json.loads. A single `//` comment or trailing comma turned the whole file into an ExtractError, so every MCP server it declared was dropped. Strict JSON is still tried first; only on a decode error are comments and trailing commas outside strings removed and the text parsed again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: N/A (found by reading the code; reproduced on
mainat 6b33dff)What changed?
Try strict JSON first; on JSONDecodeError strip
////* */comments and trailing commas outside string literals and parse again.Why?
Extractor/formats/init.py:21-23 parses "json" (incl.
.jsonc, which format_for maps to json) with strict json.loads. A VS Code user mcp.json with a// ...comment or trailing comma (VS Code treats mcp.json as JSONC; its docs' examples carry comments), or Zed's settings.json (default file opens with//comment lines), raises JSONDecodeError -> whole file becomes an ExtractError, all its MCP servers are dropped.How did you test it?
uv run --python 3.11 pytest -q adr_discovery/tests_unit/test_jsonc_configs.py-> main: 2 failed, 1 passed (declarations [] + JSONDecodeError); branch: 3 passed.pytest -q563 passed;ruff check .clean.context_serverskey is not read by _server_block at all (separate gap); this fix only removes the parse error there.Potential risks
The change only affects the input described above; other paths go through the same code as before, and the component's existing tests pass.
AI assistance: Claude Code (model Claude Opus 5.5) found this bug, wrote the fix and test, and drafted this description; submitted by @rudycelekli.
🤖 Generated with Claude Code