lint: fix niliness typo in govet config#106
Open
Saijayavinoth wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 67.94% 67.94%
=======================================
Files 32 32
Lines 2059 2059
=======================================
Hits 1399 1399
Misses 636 636
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lint: fix .golangci.yml to pass on golangci-lint v1.64.x Two changes, both surfacing because v1.64.x added strict `config verify` that older versions silently bypassed: - Fix niliness → nilness (typo in govet enable list since e66de90). Older golangci-lint silently ignored the unknown name; v1.64.x rejects it during config verification. - Exclude fmt.Fprint/Fprintf/Fprintln from errcheck. Once config verify passes, errcheck actually runs and catches conventional fmt-write callsites where the returned error is intentionally ignored. Standard exclusion in Go projects.
Saijayavinoth
force-pushed
the
fix-golangci-niliness-typo
branch
from
589e6da to
176d3d3
Compare
Author
|
@abhinav PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two latent issues in
.golangci.ymlthat both surface undergolangci-lintv1.64.x's stricterconfig verify. Currently breaking CI on every open PR — see #105 Lint job.Changes
1.
niliness→nilness(the govet analyzer name has no doublei)Typo introduced in e66de90 (Sep 2023). Older
golangci-lintversions silently ignored unknown analyzer names; v1.64.x rejects them during config verification: