Conversation
Signed-off-by: edlng <edwardliangedli@gmail.com>
Greptile SummaryThis PR successfully makes One actionable finding: The frontend Confidence Score: 4/5
Last reviewed commit: a7a5279 |
Additional Comments (1)
Consider adding a server-side refinement to ensure the business rule is enforced end-to-end: |
| check( | ||
| "chk_lower_level_bounds", | ||
| sql`${table.lowerLevel} >= 1 AND ${table.lowerLevel} <= 4`, | ||
| sql`${table.lowerLevel} IS NULL OR (${table.lowerLevel} >= 1 AND ${table.lowerLevel} <= 4)`, |
There was a problem hiding this comment.
We should make the logic be either both lower and upper are present or the both are not present. Right now I believe the logic is not exactly that.
Signed-off-by: edlng <edwardliangedli@gmail.com>
* main: chore: upgrade deps feat: nullable levels (#188)
* main: chore: upgrade deps feat: nullable levels (#188) fix: remove One-on-One Exercise 132 security dialog (#155) implement volunteer scoped availability settings content (#187) # Conflicts: # pnpm-lock.yaml # src/components/classes/constants.ts # src/components/classes/edit/content/class-general-section.tsx # src/components/classes/edit/schema.ts # src/models/api/class.ts
Closes #176
Makes it so that non-exercise classes have nullable levels (i.e., doesn't show the level slider).