Merged
Conversation
The only change is "single character" -> "string", it's just obscured by having to re-wrap the text.
Collaborator
|
I'd say this is meta but doesn't require Laurenz's approval since this is a minor documentation change. |
MDLC01
approved these changes
Jul 3, 2025
Enivex
reviewed
Jul 3, 2025
Collaborator
Author
|
Found another small oversight that I've just lumped in this PR. Technically not documentation, but an assertion error message is close enough imo. |
mkorje
previously approved these changes
Jul 4, 2025
mkorje
reviewed
Jul 4, 2025
mkorje
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were slightly out of date after #92.
I've also taken the liberty to rephrase them a bit; Ever since #46, the crate-level docs have explained what a variant is, so we can just use that word in the functions' docs.
(Not sure whether this counts as meta or not)