Skip to content

feat: add configurable logging - #12

Merged
jasonbosco merged 4 commits into
typesense:masterfrom
tharropoulos:logging
Sep 24, 2025
Merged

feat: add configurable logging#12
jasonbosco merged 4 commits into
typesense:masterfrom
tharropoulos:logging

Conversation

@tharropoulos

@tharropoulos tharropoulos commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

Change Summary

Expand on #11 to include a configurable log level parameter when configuring the gem, instead of removing loggin outright. Default log level to warn.

closes #2

PR Checklist

@jasonbosco
jasonbosco merged commit d31295f into typesense:master Sep 24, 2025
1 check passed
@jasonbosco

Copy link
Copy Markdown
Member

This is now available in v1.0.0.rc3

@cirdes

cirdes commented Sep 26, 2025

Copy link
Copy Markdown

@tharropoulos @jasonbosco

It's odd for a gem to change the Rails.logger.level or someone have to use a gem to config the Rails.logger.level of thier application.

Logger.level is something that should be configured by the user on his own application not inside a gem. This PR leads to a confusing pattners as @stephannv pointed out on his #11 (comment)

@jasonbosco

Copy link
Copy Markdown
Member

@cirdes At the risk of sounding like an LLM, you're absolutely right! #14 now fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding gem changes global logging settings.

3 participants