Conversation
larsrh
commented
Mar 3, 2021
Contributor
Author
larsrh
left a comment
larsrh
left a comment
There was a problem hiding this comment.
I noticed that there's a few settings from the sbt-release plugin still in your build. Those could probably be removed at some point.
Comment on lines
+65
to
+66
| crossScalaVersions := (ThisBuild / crossScalaVersions).value.filter(_.startsWith("2")), | ||
| publishConfiguration := publishConfiguration.value.withOverwrite(true) |
Contributor
Author
There was a problem hiding this comment.
This is required because Scalatest does not publish DottyJS artifacts.
Comment on lines
-9
to
+11
| val emptyK: List ~> List = λ[List ~> List](_ => Nil) | ||
| val emptyK = new (List ~> List) { | ||
| def apply[A](x: List[A]) = Nil | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This syntax is not supported in Dotty, so I opted to write it like this. It's only in tests, so it seemed fair to me.
| case v if v.startsWith("2.13") => Nil | ||
| case _ => Seq("-Ypartial-unification") | ||
| case v if v.startsWith("2.12") => Seq("-Ypartial-unification") | ||
| case v if v.startsWith("3") => Seq("-source", "3.0-migration") |
Contributor
Author
There was a problem hiding this comment.
This is to make Dotty shut up about missing parens in lambdas. I didn't fix them to keep the PR as small as possible.
Member
benhutchison
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.