chore: Oss publish pipeline - #934
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow intended to support OSS publishing for this PHP SDK by running release-time checks on version tags, including dependency hygiene and a full PHP test matrix, with a final “publish” gate.
Changes:
- Introduces a new
deploy.ymlworkflow triggered on release tags. - Adds lockfile hygiene + matrix test verification (PHP 7.2–8.4) with Artifactory OIDC auth.
- Adds a publish-stage validation ensuring the git tag matches
src/Twilio/VersionInfo.php(publishing-related steps are currently commented out).
Suppressed comments (1)
.github/workflows/deploy.yml:65
runs-on: ubuntu-x64is inconsistent with the other workflows in this repo (which useubuntu-latest) and may not be a valid GitHub-hosted runner label, which would prevent the job from being scheduled.
runs-on: ubuntu-x64
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| on: | ||
| push: | ||
| tags: | ||
| - '[0-9]+.[0-9]+.[0-9]+' |
Comment on lines
+15
to
+17
| composer-lockfile-hygiene: | ||
| runs-on: ubuntu-x64 | ||
| steps: |
| verify: | ||
| name: Verify - PHP ${{ matrix.php }} | ||
| needs: [composer-lockfile-hygiene] | ||
| runs-on: ubuntu-x64 |
| - name: Validate tag format and version match | ||
| run: | | ||
| TAG="${GITHUB_REF#refs/tags/}" | ||
| if [[ ! "$TAG" =~ ^[0-9]+\.[0-9]+\.[0-9]+ ]]; then |
Comment on lines
+68
to
+71
| permissions: | ||
| contents: write | ||
| id-token: write | ||
| attestations: write |
Comment on lines
+62
to
+67
| publish: | ||
| name: Publish to Packagist | ||
| needs: [verify] | ||
| runs-on: ubuntu-x64 | ||
| if: success() && github.ref_type == 'tag' && github.repository_owner == 'twilio' | ||
| environment: production |
shrutiburman
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oss publishing pipeline for php