Skip to content

Remove namespace in SetUpFixture#6

Open
timbussmann wants to merge 2 commits into
twenzel:masterfrom
timbussmann:patch-1
Open

Remove namespace in SetUpFixture#6
timbussmann wants to merge 2 commits into
twenzel:masterfrom
timbussmann:patch-1

Conversation

@timbussmann

@timbussmann timbussmann commented Mar 14, 2019

Copy link
Copy Markdown

the setup shouldn't have a namespace because otherwise the tests imported from the NServiceBus.ContainerTests.Sources package use the built-in LightInject builder.

Caution: This change breaks a lot of tests!

@timbussmann

Copy link
Copy Markdown
Author

ping @twenzel

@twenzel

twenzel commented Jul 30, 2019

Copy link
Copy Markdown
Owner

I'll have a look at this

@timbussmann

Copy link
Copy Markdown
Author

@twenzel any plans of applying this change? Otherwise, I'm going to close this PR.

@twenzel

twenzel commented Oct 4, 2019

Copy link
Copy Markdown
Owner

I'm currently looking at the failed tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants