fix: preserve script objects in to-zen containers - #70
Open
mvanhorn wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the existing
to-zendiscovery and deserialization ofscriptobjects.bin, then serialize the parsedZenScriptObjectsinto the generated container withIoStoreWriter::write_chunkand the globalScriptObjectschunk ID before finalization. Reuse the serialization and chunk-writing pattern already used bygen-script-objects, factoring only a small production helper if that makes the behavior directly testable from the existing inline test module.to-zenaccepts a legacy input containingscriptobjects.binand deserializes it so asset imports can be validated during conversion. The command does not add that metadata to the generated IoStore container, even though newer containers expect it in the globalScriptObjectschunk.Convert or exercise the writer path with a valid
scriptobjects.bin, reopen the generated container, and verify the global ScriptObjects chunk exists and deserializes successfully; Verify the preserved metadata retains the source script-object entries rather than writing an empty or example-specific chunk.Fixes #50