Conversation
brycentrivir
changed the title
src/cli/authz/authz-policy-export.ts
Outdated
| new Option( | ||
| '-M, --modified-properties', | ||
| 'Include modified properties in export (e.g. lastModifiedDate, lastModifiedBy, etc.)' | ||
| 'Include modified properties in export (e.g. lastModifiedDate, lastModifiedBy, createdBy, creationDate, etc.)' |
There was a problem hiding this comment.
You included your changes from the creation branch. We don't want to do that. I think you probably did git checkout -b ... from your remove creation timestamps branch, so that's why you have these changes. When you create a new branch, you want to first checkout the "main" branch first before doing the git checkout -b ... command so you branch off of main instead of another branch. You can fix this though by doing an interactive rebase.
The other option is you can wait for your create dates PR to be merged into main, at which point you do a rebase against main and then you won't need to make any changes to this PR. You may want to do this since both PRs modify the script tests (there will be merge conflicts if you try and drop the creation dates commit from this one), so you could also do that as well
| const outcome = await exportServersToFile( | ||
| options.file, | ||
| options.extract, | ||
| false, |
There was a problem hiding this comment.
Something I realized is that we should probably just remove specifying the extract flag here entirely from the exportServersToFile function since that really shouldn't exist for it. So instead of doing false here, we just remove that parameter from the function entirely
There was a problem hiding this comment.
I'd remove this mock since currently the config export tests are being skipped, so we don't need it
There was a problem hiding this comment.
I'd remove this mock since currently the config export tests are being skipped, so we don't need it
There was a problem hiding this comment.
I'd remove this mock since currently the config export tests are being skipped, so we don't need it
There was a problem hiding this comment.
I'd remove this mock since currently the config export tests are being skipped, so we don't need it
There was a problem hiding this comment.
I'd remove this mock since currently the config export tests are being skipped, so we don't need it
brycentrivir
force-pushed
the
feature/make-extraction-default
branch
from
c0b41fb to
891fcb7
Compare
|
creating PR for rockcarver, Preston was at my desk for approval |
2 participants
Added default (true) to the options for export in node, config, script, and server export files. Afterwards had to work on rebuilding a few tests to get all to pass correctly.