feat: Add config-manager push connector-definitions command#80
Open
dallinjsevy wants to merge 2 commits intomainfrom
Open
feat: Add config-manager push connector-definitions command#80dallinjsevy wants to merge 2 commits intomainfrom
dallinjsevy wants to merge 2 commits intomainfrom
Conversation
dallinjsevy
force-pushed
the
feature/config-manager-push-connector-definitions
branch
4 times, most recently
from
db3cb16 to
65955be
Compare
phalestrivir
force-pushed
the
feature/config-manager-push-connector-definitions
branch
from
65955be to
8fb166d
Compare
phalestrivir
requested changes
Mar 31, 2026
src/cli/config-manager/config-manager-push/config-manager-push-connector-definitions.ts
Outdated
Show resolved
Hide resolved
dallinjsevy
force-pushed
the
feature/config-manager-push-connector-definitions
branch
from
8fb166d to
e7a2b14
Compare
phalestrivir
requested changes
Apr 3, 2026
| } | ||
|
|
||
| /** | ||
| * Import all mappings in fr-config-manager format |
There was a problem hiding this comment.
Shoulds say "connectors" instead of mappings
| * @returns {Promise<boolean>} true if successful, false otherwise | ||
| */ | ||
| export async function configManagerImportDefinitions( | ||
| name: string |
There was a problem hiding this comment.
should have name be optional: name?: string
There was a problem hiding this comment.
Don't need to include this change.
There was a problem hiding this comment.
Don't need to include this change.
There was a problem hiding this comment.
Tests should be configured to be against Forgeops and not Cloud. I sent a document on how to setup an RCS with connectors in the Frodo chat, so use that to be able to do the tests. I would create another connector in addition to your "test" connector to test importing multiple connectors (you can just use a simple CSV file connector since those are the simplest to configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.