fix: set Fast Forward evaluation time from range end - #1101
Merged
jranson merged 1 commit intoAug 4, 2026
Conversation
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
jranson
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prometheus Fast Forward removed the range parameters without setting the instant query's
time. In a TSM pool, terminal origins could therefore evaluate one request at different epochs and leave aggregate contributions split across several points.This promotes the original range
endtotimeunchanged before removingstart,end, andstep. It also covers GET and POST forms plus a two-member TSM request that must produce one summed Fast Forward point at the requested epoch.Fixes #1100
Type of Change
AI Disclosure