Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,17 @@ on:

jobs:
build:
# Named explicitly so that `experimental` stays out of the job name.
name: "build (${{ matrix.ruby }}, ${{ matrix.rails }}, ${{ matrix.ember }})"
runs-on: "ubuntu-latest"

# Jobs normally finish in about 3 minutes; a hung job once ran for
# 2 hours until it was cancelled by hand, so cap the runtime.
timeout-minutes: 15

# Rails main is a moving target, so let it break without failing the build.
continue-on-error: ${{ matrix.experimental || false }}

strategy:
fail-fast: false
matrix:
Expand All @@ -25,14 +30,10 @@ jobs:
# versions use the classic Broccoli-based build.
ember: ["7.0.0"]
include:
# Disabled: rspec-rails 6.x (the newest the gemspec allows)
# fails to load specs against rails/rails main with
# `FrozenError: can't modify frozen Hash`. Re-enable once the
# rspec-rails dependency can be upgraded to a series that
# supports Rails main.
# - ruby: "4.0"
# rails: "main"
# ember: "7.0.0"
- ruby: "4.0"
rails: "main"
ember: "7.0.0"
experimental: true
# Classic (Broccoli-based) blueprint coverage
- ruby: "3.4"
rails: "8.1"
Expand Down
8 changes: 8 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,11 @@ gem "rails", rails_constraint
gem "high_voltage", "~> 3.0.0"
gem "selenium-webdriver", ">= 4.11"
gem "webrick"

if rails_version == "main"
# The released rspec-rails series mutates internals that Rails main
# freezes, failing the suite while loading the specs. Until a release
# carries the fixes (e.g. https://github.com/rspec/rspec-rails/pull/2915),
# test against rspec-rails main.
gem "rspec-rails", github: "rspec/rspec-rails", branch: "main"
end
2 changes: 1 addition & 1 deletion ember-cli-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "html_page", "~> 0.1.0"

spec.add_development_dependency "generator_spec", "~> 0.9.0"
spec.add_development_dependency "rspec-rails", ">= 3.6.0", "< 7.0"
spec.add_development_dependency "rspec-rails", ">= 3.6.0", "< 9.0"

spec.add_development_dependency "capybara-selenium"
spec.add_development_dependency "codeclimate-test-reporter", "~> 0.6.0"
Expand Down