Fixes several bugs found by parsing configure - #330
Open
thatch wants to merge 1 commit into
Open
Conversation
See new tests in test/corpus/statements.txt that cover these cases. The common theme was that the `if` block would be parsed as ending earlier than it really does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, the problem I'm trying to solve: parse a generated autoconf "configure" script to analyze variable dependencies among the checks.
Prior to this change, many of the checks aren't whole (for example, treating
ifas a command, not as going up until a correspondingfi), and despite the length of this PR I believe this is the minimal changes necessary to parse the cpython 3.15 configure script. (note: not 100% sure this is enough yet, but it's enough that I have bigger issues in my own code rather than the syntactic parsing)See new tests in test/corpus/statements.txt that cover these cases.
P.S. This actually comes a little full circle for me, I added the pygments bash lexer testing against a configure script almost 20 years ago.