Skip to content

workflows/artifacts: use stable rustc to install elf2tab - #508

Closed
lschuermann wants to merge 1 commit into
tock:masterfrom
lschuermann:dev/elf2tab-pin-rustc-artifacts
Closed

workflows/artifacts: use stable rustc to install elf2tab#508
lschuermann wants to merge 1 commit into
tock:masterfrom
lschuermann:dev/elf2tab-pin-rustc-artifacts

Conversation

@lschuermann

Copy link
Copy Markdown
Member

This applies the same hack of #486 to work around our current rust-toolchain being too old to build elf2tab.

This applies the same hack of tock#486 to work around our
current rust-toolchain being too old to build elf2tab.
@jrvanwhy

Copy link
Copy Markdown
Collaborator

Do we still want this with #513 merged? At the moment we're using the MSRV Rust toolchain to install elf2tab in the CI workflow (as well as on developer machines). The artifacts workflow should probably be synchronized with the CI workflow.

I was thinking we'd update the MSRV if a new elf2tab release requires a newer toolchain, but alternatively we could use the nightly toolchain to install elf2tab. Either option avoids adding a third toolchain to libtock-rs's dependencies.

@lschuermann

Copy link
Copy Markdown
Member Author

I agree we wouldn't want this with #513. It doesn't make sense for us to target an MSRV if we can't use it to build a core piece of our toolchain, such as elf2tab. If elf2tab requires a newer version of Rust, let's bump our MSRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants