fix(optimizer): keep projections referenced by SORT BY / DISTRIBUTE BY / CLUSTER BY - #8302
Open
fivetran-kwoodbeck wants to merge 3 commits into
Open
fix(optimizer): keep projections referenced by SORT BY / DISTRIBUTE BY / CLUSTER BY#8302fivetran-kwoodbeck wants to merge 3 commits into
fivetran-kwoodbeck wants to merge 3 commits into
Conversation
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing:
Overallmain: 182937 total, 163862 passed (pass rate: 89.6%) sqlglot:fix/pushdown-projections-spark-sort-distribute-cluster: 182937 total, 163862 passed (pass rate: 89.6%) Transitions: ✅ All tests passed |
geooo109
reviewed
Sep 3, 2026
fivetran-kwoodbeck
force-pushed
the
fix/pushdown-projections-spark-sort-distribute-cluster
branch
from
September 3, 2026 19:34
42a4bf5 to
ccfc48c
Compare
georgesittas
reviewed
Sep 3, 2026
georgesittas
reviewed
Sep 3, 2026
georgesittas
approved these changes
Sep 4, 2026
georgesittas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM once final concern(s) are addressed. @geooo109 wanna take another look?
fivetran-kwoodbeck
force-pushed
the
fix/pushdown-projections-spark-sort-distribute-cluster
branch
from
September 4, 2026 18:04
ccfc48c to
16da147
Compare
geooo109
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pushdown_projectionskept projections referenced byORDER BY, but Spark'sSORT BY,DISTRIBUTE BYandCLUSTER BYcan reference select aliases too and were not checked, so their projections were pruned. Treat all three clauses as output references, hoisting them onto the exp.SetOperation when they trail a set operation so both arms keep the projection.