Repository navigation
Preserve fractional sweep frequencies when restoring settings - #479
Open
WillHirsch wants to merge 1 commit into
Open
WillHirsch wants to merge 1 commit into
WillHirsch wants to merge 1 commit into
Conversation
Read the start and stop frequencies as floats, matching their properties and saved settings. Cover floating-point QSettings values and fractional text from a fresh INI file. Fixes tlecomte#478.
WillHirsch
added a commit
to WillHirsch/polyfriture
that referenced
this pull request
Oct 19, 2026
Merge the branch submitted in tlecomte#479, preserving the upstream fix and regression tests. Git resolves the package rename into polyfriture/ without changing the reviewed patch contents.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring the Sweep generator's start and stop frequencies now reads floating-point values, matching the properties and saved settings. A saved 20.50 Hz value therefore retains its precision, and fractional values loaded from an INI file no longer trigger an integer-conversion error.
Closes #478.
Two regression tests cover a save/restore roundtrip and a fresh INI file containing fractional values. They use temporary settings stores and do not require audio hardware.
Validation
TypeError.git diff --checkpasses.The patch changes only sweep settings restoration and its regression tests.