Fix PHP CALL extraction: add support for method, static, and unqualified function calls #297#298
Fix PHP CALL extraction: add support for method, static, and unqualified function calls #297#298Bakul2006 wants to merge 1 commit intotirth8205:mainfrom
Conversation
|
Tested this PR locally against OpenEMR (4,770 files, a large PHP codebase). Results are dramatic:
Spot-checking the top targets shows real PHP patterns now resolve correctly — method calls ( Sample blast-radius query on The One small observation: the LGTM from an end-user perspective. Thanks for the fast turnaround. |
Root cause: PHP node child-type mismatch in _get_call_name.
Fix: PHP-specific handling + scoped/nullsafe node coverage + regression tests.
Addressing the issue #297 and #273
Changes
Expanded PHP call node coverage in parser call node configuration.
Added PHP-specific call-name extraction logic