discard the extended checksum part in row values#739
Open
zyguan wants to merge 2 commits intotikv:masterfrom
Open
discard the extended checksum part in row values#739zyguan wants to merge 2 commits intotikv:masterfrom
zyguan wants to merge 2 commits intotikv:masterfrom
Conversation
Signed-off-by: zyguan <zhongyangguan@gmail.com>
|
The latest updates on TiDB Cloud Branch. Learn more about TiDB Cloud ↗︎
|
17 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
============================================
- Coverage 37.93% 37.76% -0.18%
+ Complexity 1613 1603 -10
============================================
Files 278 278
Lines 17517 17522 +5
Branches 1992 1994 +2
============================================
- Hits 6645 6617 -28
- Misses 10208 10237 +29
- Partials 664 668 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shiyuhang0
previously approved these changes
May 31, 2023
Collaborator
|
roughly approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref pingcap/tidb#42747
Problem Description:
Row values now may have extended checksums since pingcap/tidb#42859, so client-java need to discard these checksums on read.
What is changed and how does it work?
Do not copy the checksum part to
RowV2.data. Actually the current implementation is ok sinceRowV2.datacan be only accessed byRowV2.getData. This PR just makes it more safer.