Draft
Conversation
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
c550c7d to
8a350c5
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
This pull request introduces a new
Sequentialprocessor to the accelerated image processor pipeline, enabling the composition and sequential execution of multiple image processors. It also updates the build system and documentation to support and explain this new feature, and adds relevant tests and examples. Additionally, there are some improvements to camera info handling and dependency management.Major new functionality:
Sequentialprocessor, which allows chaining multiple processors and executing them in order. Includes support for registering post-processing callbacks and propagating camera info through the pipeline. [1] [2]Sequentialprocessor inexamples/example_sequential.cppand updated the documentation with usage instructions. [1] [2]Build system and dependency updates:
CMakeLists.txtto build and test the newSequentialprocessor, add the example, and link against the new compression dependency. [1] [2] [3]package.xml.Camera info handling improvements:
BaseProcessorandRectifierto allow for better integration with the new sequential pipeline. [1] [2] [3]Testing improvements:
Sequentialprocessor, including cases for appending processors with and without callback functions.Other updates:
sequential.hppheader in the ROS parameter header for broader integration.The example usage of
Sequentialis as follows (see examples/example_sequential.cpp for details):Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks