Open
Conversation
6ddc528 to
3328692
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
3328692 to
1e2ee91
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
d6f5b71 to
589c6a8
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive benchmarking package for accelerated image processing, enabling performance measurement with both synthetic images and ROSBag data. The package provides a command-line tool for running compression benchmarks with flexible configuration and detailed performance reporting.
Changes:
- Added
Benchmarkerclass for timing image processing operations and calculating performance metrics (average, percentile, FPS) and storage ratios - Implemented synthetic image generation for testing without external data dependencies
- Created
compressionCLI tool with support for both synthetic images and ROSBag input sources
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/accelerated_image_processor_benchmark/CMakeLists.txt | Build configuration for the benchmark package, including dependencies and executable targets |
| src/accelerated_image_processor_benchmark/package.xml | ROS package metadata and dependencies |
| src/accelerated_image_processor_benchmark/README.md | User documentation for installation and usage |
| src/accelerated_image_processor_benchmark/include/accelerated_image_processor_benchmark/benchmarker.hpp | Header defining the Benchmarker class for performance measurement |
| src/accelerated_image_processor_benchmark/include/accelerated_image_processor_benchmark/image.hpp | Header declaring synthetic image generation function |
| src/accelerated_image_processor_benchmark/include/accelerated_image_processor_benchmark/rosbag.hpp | Header defining RosBagReader class for reading image messages |
| src/accelerated_image_processor_benchmark/include/accelerated_image_processor_benchmark/utility.hpp | Header declaring utility functions for configuration and processor management |
| src/accelerated_image_processor_benchmark/src/benchmarker.cpp | Implementation of benchmarking logic including timing, statistics, and reporting |
| src/accelerated_image_processor_benchmark/src/image.cpp | Implementation of synthetic image generation with random noise |
| src/accelerated_image_processor_benchmark/src/compression.cpp | CLI tool for running compression benchmarks |
| src/accelerated_image_processor_benchmark/src/utility.cpp | Implementation of configuration loading, image loading, and processor utilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
457e91c to
20d6c05
Compare
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
This pull request introduces a new benchmarking library for accelerated image processing, including comprehensive benchmarking functionality, command-line benchmarking tools, and support for both synthetic and ROSBag image data. It establishes the project structure, adds core benchmarking logic, and provides utilities for configuration and processor management.
Core benchmarking functionality:
Benchmarkerclass for measuring and reporting image processing performance, including methods for timing, statistics, and storage ratio calculations (benchmarker.hpp,benchmarker.cpp). [1] [2]make_synthetic_imagefunction, enabling benchmarking with generated data (image.hpp,image.cpp). [1] [2]Command-line benchmarking tool:
compressionCLI tool for running compression benchmarks, supporting both synthetic images and images from ROSBag, with flexible configuration and reporting (compression.cpp).README.md.ROSBag and configuration utilities:
RosBagReaderclass for reading image messages from ROSBag files, supporting multiple storage backends (rosbag.hpp).utility.hpp).Project setup:
CMakeLists.txtandpackage.xmlfiles to define dependencies, build configuration, and installation for the new benchmarking package. [1] [2]How to Use
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to accelerated_image_processor_benchmark source install/setup.bashaccbench compression <CONFIG_PATH> [...]Compression benchmark with synthetic images
Compression benchmark with ROSBag
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks