tests: add edge-case tests for str_count()#609
Closed
LeonidasZhak wants to merge 1 commit into
Closed
Conversation
- NA input returns NA_integer_ - Empty string returns 0L - Empty character vector returns integer() - NA pattern errors with informative message - Non-overlapping regex match counting - Multibyte character counting
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds edge-case tests for
str_count()covering data cleaning scenarios that were previously untested.Tests Added
str_count(NA, "a")returnsNA_integer_; vector with mixed NA propagates correctlystr_count("", "a")returns0L; empty character vector returnsinteger()str_count("abc", NA_character_)errors with informative message"aaa"with"aa"counts 1,"aaaa"counts 2)Validation
devtools::load_all(); test_file('tests/testthat/test-count.R')expect_error()instead ofexpect_snapshot()for error test)Files Changed
tests/testthat/test-count.R— Added 25 lines (5 test blocks)