Repository navigation
Fix cases where a line touches a polygon boundary but does not share vertices - #33
Merged
Merged
Conversation
* add the first failing case * add some failing comented out cases * uncomment them * generated change * remove the multiline cases and start from main * implement contains with with min dim handling * touches update * fix remaining within/contains cases
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not open a pull request without first filing an issue and/or discussing the feature directly with me.
Please ensure you adhere to every item in this list
Describe your changes
This PR fixes a few cases
Codex did these implementations...
ring_vertex_is_convex_tangent()is the one I'm the least sure about but essentially covers the case (theory being a concave vertex with a tangent segment can't merely be touching).Issue number and link
Pull request require a prior issue with discussion.
Include the issue number of link here.