Skip to content

Apply fixes from StyleCI #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thyyppa wants to merge 1 commit into
base: field_meta
Choose a base branch
from
Open

Apply fixes from StyleCI #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions src/Connection/FluentFMRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,22 +73,22 @@ public function find(string $layout): FluentFM

return $this;
}
/**

/**
* {@inheritdoc}
*/
public function valueList(string $layout, string $field): array
{
$response = $this->client->get(Url::layout($layout), [
'Content-Type' => 'application/json',
'headers' => $this->authHeader()
'headers' => $this->authHeader(),
]);
Response::check($response, []);

$fieldMetaDataList = Response::body($response)->response->fieldMetaData;
$fieldMetaData = $this->getFieldMetaData($layout, $fieldMetaDataList, $field);

if (!array_key_exists('valueList', $fieldMetaData)) {
if (! array_key_exists('valueList', $fieldMetaData)) {
throw new FilemakerException("The field '$field' does not have an associated value list on layout '$layout'");
}

Expand All @@ -100,21 +100,22 @@ public function valueList(string $layout, string $field): array
}

/**
* Get specific valueList
*
* @param array $valueLists
* @param string $valueListName
* @return array
* Get specific valueList.
*
* @param array $valueLists
* @param string $valueListName
* @return array
*/
protected function getFieldValueList(array $valueLists, string $valueListName): array
{
$values = [];

foreach ($valueLists as $valueList) {
if ($valueList->name === $valueListName)
if ($valueList->name === $valueListName) {
foreach ($valueList->values as $item) {
$values[$item->displayValue] = $item->value;
}
}
}

return $values;
Expand All @@ -127,7 +128,7 @@ public function fieldMeta(string $layout, string $field): array
{
$response = $this->client->get(Url::layout($layout), [
'Content-Type' => 'application/json',
'headers' => $this->authHeader()
'headers' => $this->authHeader(),
]);

Response::check($response, []);
Expand All @@ -139,13 +140,13 @@ public function fieldMeta(string $layout, string $field): array
}

/**
* Get specific fieldMetaData
*
* @param string $layout
* @param array $fieldMetaDataList
* @param string $field
* @return array
* @throws \Hyyppa\FluentFM\Exception\FilemakerException
* Get specific fieldMetaData.
*
* @param string $layout
* @param array $fieldMetaDataList
* @param string $field
* @return array
* @throws \Hyyppa\FluentFM\Exception\FilemakerException
*/
protected function getFieldMetaData(string $layout, array $fieldMetaDataList, string $field): array
{
Expand All @@ -155,7 +156,7 @@ protected function getFieldMetaData(string $layout, array $fieldMetaDataList, st
$fields[strtolower($value_list->name)] = $value_list;
}

if (!array_key_exists(strtolower($field), $fields)) {
if (! array_key_exists(strtolower($field), $fields)) {
throw new FilemakerException("Metadata for field '$field' not found on layout '$layout'");
}

Expand Down