docs: repoint the migration/health follow-up refs at live issues - #52
Open
aatchison wants to merge 2 commits into
Open
docs: repoint the migration/health follow-up refs at live issues#52aatchison wants to merge 2 commits into
aatchison wants to merge 2 commits into
Conversation
added 2 commits
August 10, 2026 15:51
The ENTRYPOINT comment cited platform-infrastructure#144 as tracking the pre-sync migration Job. #144 is a CLOSED milestone, so the work was not tracked anywhere — it just read as though it was, which is worse than no reference. Repointed at thunderbird-accounts#1191 (move migrate out of the entrypoint) and added #1192 (GET /health returns 200 regardless of dependency state, and 500s when Keycloak or Stalwart is unreachable) next to the HEALTH note, since that is why overlays/tb-dev substitutes a bare TCP readiness probe. Comment-only. Verified `kubectl kustomize overlays/tb-dev` output is byte-identical before and after.
A 20-lens fact-check of both issues confirmed two overstatements that this comment had inherited: - "prerequisite for blue-green" -> "makes blue-green unsafe rather than impossible". appointment-backend on the same cluster is a blueGreen Rollout with prePromotionAnalysis whose entrypoint runs Alembic on boot, at 2 replicas -- so migrate-on-boot demonstrably does not block the pattern, it removes the gate's protection. - "/health returns 200 regardless of dependency state" -> "its status code never reflects dependency state". The endpoint does not always return 200; per the issue's own second point it 500s when a dependency is unreachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only.
kubectl kustomize overlays/tb-devoutput is byte-identical before and after.bases/accounts/web-deployment.yamlcitedplatform-infrastructure#144as tracking the pre-sync migration Job. #144 is a closed milestone, so that work was tracked nowhere — the reference just made it look tracked, which is worse than having none.migrateout of the entrypoint), with one line on why it blocks blue-green./healthreturns 200 regardless of dependency state, and 500s if Keycloak or Stalwart is unreachable), since that is whyoverlays/tb-devsubstitutes a bare TCP readiness probe — plus a note to revert that override once it lands.