Skip to content

fix(upload-submission-modal): resolve upgraded modal dependency issue #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheshankarvapally wants to merge 2 commits into
base: 10.0.x
Choose a base branch
from
Open

fix(upload-submission-modal): resolve upgraded modal dependency issue #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5246a3
fix(upload-submission-modal): migrate modal service to uibModal
sheshankarvapally May 6, 2026
7ac84ea
fix(task-submission-card): remove circular uploadSubmissionModal depe…
sheshankarvapally May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ...rectives/task-dashboard/directives/task-submission-card/task-submission-card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Component, Inject, Input, OnChanges, OnInit, SimpleChanges } from '@angular/core';
import { uploadSubmissionModal } from 'src/app/ajs-upgraded-providers';
import { Component, Input, OnChanges, OnInit, SimpleChanges } from '@angular/core';
import { Task } from 'src/app/api/models/task';
import { TaskService } from 'src/app/api/services/task.service';
import { FileDownloaderService } from 'src/app/common/file-downloader/file-downloader.service';
Expand All @@ -18,11 +17,11 @@ export class TaskSubmissionCardComponent implements OnChanges, OnInit {
urls: { pdf: string; files: string };

constructor(
private taskService: TaskService,
@Inject(uploadSubmissionModal) private UploadSubmissionModal,
private alerts: AlertService,
private fileDownloader: FileDownloaderService
) {}
private taskService: TaskService,
private alerts: AlertService,
private fileDownloader: FileDownloaderService
) {}


ngOnInit(): void {
if (this.task) {
Expand Down Expand Up @@ -81,4 +80,4 @@ export class TaskSubmissionCardComponent implements OnChanges, OnInit {
downloadSubmissionFiles(): void {
this.fileDownloader.downloadFile(this.urls.files, `${this.task.definition.abbreviation}.zip`);
}
}
}
4 changes: 2 additions & 2 deletions src/app/tasks/modals/upload-submission-modal/upload-submission-modal.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ angular.module('doubtfire.tasks.modals.upload-submission-modal', [])
#
# A modal to run through uploading a submission
#
.factory('UploadSubmissionModal', ($modal, alertService) ->
.factory('UploadSubmissionModal', ($uibModal, alertService) ->
UploadSubmissionModal = {}
#
# Open a grade task modal with the provided task
Expand All @@ -20,7 +20,7 @@ angular.module('doubtfire.tasks.modals.upload-submission-modal', [])
# task.project = -> project
task.isTestSubmission = isTestSubmission

$modal.open
$uibModal.open
templateUrl: 'tasks/modals/upload-submission-modal/upload-submission-modal.tpl.html'
controller: 'UploadSubmissionModalCtrl'
size: 'lg'
Expand Down