Skip to content

Investigate config module dependencies and clean up legacy root-controller usage #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheshankarvapally wants to merge 4 commits into
base: 10.0.x
Choose a base branch
from
Open

Investigate config module dependencies and clean up legacy root-controller usage #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfb9bec
Investigate config dependencies and clean up legacy root-controller u…
sheshankarvapally Apr 22, 2026
a928450
refactor: investigate AngularJS config dependency cleanup for Angular…
sheshankarvapally May 5, 2026
ffde53a
fix(upload-submission-modal): migrate modal service to uibModal
sheshankarvapally May 6, 2026
4fd0c5a
Fix duplicate comma in module dependencies
sheshankarvapally May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/app/config/config.coffee
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions src/app/config/root-controller/root-controller.coffee
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions src/app/config/routing/routing.coffee
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions src/app/config/runtime/runtime.coffee
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions src/app/doubtfire-angularjs.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ import 'build/src/app/tasks/task-ilo-alignment/modals/task-ilo-alignment-modal/t
import 'build/src/app/tasks/task-ilo-alignment/task-ilo-alignment-editor/task-ilo-alignment-editor.js';
import 'build/src/app/tasks/task-ilo-alignment/task-ilo-alignment-viewer/task-ilo-alignment-viewer.js';
import 'build/src/app/config/privacy-policy/privacy-policy.js';
import 'build/src/app/config/runtime/runtime.js';
import 'build/src/app/config/config.js';
import 'build/src/app/config/root-controller/root-controller.js';
import 'build/src/app/config/routing/routing.js';

import 'build/src/app/config/vendor-dependencies/vendor-dependencies.js';
import 'build/src/app/config/analytics/analytics.js';
import 'build/src/app/config/debug/debug.js';
Expand Down Expand Up @@ -244,7 +241,10 @@ import {TutorNotesComponent} from './projects/states/tutor-notes/tutor-notes.com

export const DoubtfireAngularJSModule = angular
.module('doubtfire', [
'doubtfire.config',
'doubtfire.config.vendor-dependencies',
'doubtfire.config.analytics',
'doubtfire.config.debug',
'doubtfire.config.privacy-policy',
'doubtfire.sessions',
'doubtfire.common',
'doubtfire.errors',
Expand Down
4 changes: 2 additions & 2 deletions src/app/tasks/modals/upload-submission-modal/upload-submission-modal.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ angular.module('doubtfire.tasks.modals.upload-submission-modal', [])
#
# A modal to run through uploading a submission
#
.factory('UploadSubmissionModal', ($modal, alertService) ->
.factory('UploadSubmissionModal', ($uibModal, alertService) ->
UploadSubmissionModal = {}
#
# Open a grade task modal with the provided task
Expand All @@ -20,7 +20,7 @@ angular.module('doubtfire.tasks.modals.upload-submission-modal', [])
# task.project = -> project
task.isTestSubmission = isTestSubmission

$modal.open
$uibModal.open
templateUrl: 'tasks/modals/upload-submission-modal/upload-submission-modal.tpl.html'
controller: 'UploadSubmissionModalCtrl'
size: 'lg'
Expand Down
2 changes: 1 addition & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
rel="stylesheet"
/>
</head>
<body ng-controller="AppCtrl" class="mat-typography">
<body class="mat-typography">
<app-header></app-header>
<splash-screen> </splash-screen>
<div class="container-fluid" ui-view="main"></div>
Expand Down