fix(config): enable sitemap generation#82
Open
jmirchh75 wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for ontrackdocumentation ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jmirchh75
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the 'site' configuration option to 'astro.config.mjs' to support sitemap generation.
The build previously produced a warning that the sitemap integration requires the 'site' Astro config option. This was resolved by adding the documentation site URL within the file.
Build before changes; warning:
Build after changes; no warning:
This was previously submitted as a separate PR, however enabling sitemap generation saw a Netlify build failure within the
@astrojs/sitemapintegration, meaning the site did not build. To resolve this, a compatible sitemap package was installed (@astrojs/sitemap v3.6.0) and tested locally with no new warnings.Fixes # (issue)
Type of change
expected)
How Has This Been Tested?
This was tested locally by running:
This was also tested after creation of the PR, in which GitHub performed checks and all tests passed.
Testing Checklist
Checklist