fix(config): add site URL for sitemap generation#80
Closed
jmirchh75 wants to merge 1 commit into
Closed
Conversation
❌ Deploy Preview for ontrackdocumentation failed.
|
|
Looks good to me. I tested this in my local environment as well and had no issues with Julian's code. |
YG-GOV
reviewed
May 12, 2026
YG-GOV
left a comment
YG-GOV
left a comment
There was a problem hiding this comment.
Reviewed the PR and the changes look good overall.
The CI/build check passed successfully and the sitemap configuration update makes sense.
The current failing checks seem related to Netlify deploy issues rather than the actual code changes themselves. Nice work.
Contributor
|
Resolves the sitemap warning cleanly and CI passes. Looks good to me. |
Collaborator
|
It doesn't look like you have done everything required to get the sitemap working. For instance, you have removed the warning, but now Netlify cannot build the site. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the 'site' configuration option to 'astro.config.mjs' to support sitemap generation.
The build previously produced a warning that the sitemap integration requires the 'site' Astro config option. This was resolved by adding the documentation site URL within the file.
Build before changes; warning:
Build after changes; no warning:
Type of change
How Has This Been Tested?
The following command was run locally:
Testing Checklist
Checklist