feat(security): implement automated SQLi validation suite for API authentication#79
feat(security): implement automated SQLi validation suite for API authentication#79anaghwadhwa123 wants to merge 12 commits into
Conversation
✅ Deploy Preview for ontrackdocumentation ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Looks good overall, I think making the SQL injection testing executable is a useful addition. However, two things,I noticed the new script seems to remove some existing features like CLI options, valid credential checks, timeout handling, testing both username and password fields, and Nikto integration. Maybe it would be worth keeping those parts if they are still useful? Also, the detection logic might be a bit broad since checking for 'user' in the response could cause false positives. Maybe it could check for a clearer successful login response, such as a status code and auth token. |
Thank you for your feedback Leeon. I've re-implemented the CLI options, timeout handling, and Nikto integration. I also updated the detection logic to specifically look for authentication tokens rather than just general user strings to prevent false positives. |
…o integration & multi-field testing
|
Good PR, making the SQLi tests executable is a nice improvement and the feedback from Leeon was addressed well. Good work. |
jmirchh75
left a comment
There was a problem hiding this comment.
Changes as per Leeon's feedback make it solid. Previous issues were fixed which I didn't get a chance to comment on, which would have been found via testing. Looks good.
There was a problem hiding this comment.
Revert this file to the version against thoth-tech:main. Package-lock changes are outside of the scope of this PR.
There was a problem hiding this comment.
What does this file have to do with SQLi validation suite?
There was a problem hiding this comment.
What does this file have to do with SQLi validation suite?
SteveDala
left a comment
There was a problem hiding this comment.
Please double check if all the files here are within the scope of the PR.
Description
This PR introduces an automated security testing script, test-sql-injection.sh, located within the injection test documentation directory. This tool is designed to proactively identify SQL injection vulnerabilities within the doubtfire-api authentication endpoints. By moving beyond static documentation, this "Executable Documentation" allows developers to run real-world attack simulations against their local environments to ensure compliance with our security standards.
Type of change
How Has This Been Tested?
The script was tested through a local simulation and environment probe:
Testing Checklist
Checklist