Skip to content

ci: update node version and add build check#77

Open
jmirchh75 wants to merge 1 commit into
thoth-tech:mainfrom
jmirchh75:ci/update-node-build-check
Open

ci: update node version and add build check#77
jmirchh75 wants to merge 1 commit into
thoth-tech:mainfrom
jmirchh75:ci/update-node-build-check

Conversation

@jmirchh75
Copy link
Copy Markdown
Contributor

Description

This PR updates the CI workflow to use newer GitHub Actions versions, and upgrades Node to v20 LTS. It also adds a build step so that CI verifies the Astro site builds successfully during pull requests.

The previous CI workflow configuration used an EOL version of Node (v16.14.2), therefore no longer receiving security updates. Updating to Node v20 improves overall security and stability.

Fixes: N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This was tested locally to ensure there were no issues. The following commands were run:

npm install
npm run format:check
npm run build

All commands completed successfully, resulting in the expected output.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 27, 2026

Deploy Preview for ontrackdocumentation ready!

Name Link
🔨 Latest commit 58ef05c
🔍 Latest deploy log https://app.netlify.com/projects/ontrackdocumentation/deploys/69ef7c07bdb24a00086d10fd
😎 Deploy Preview https://deploy-preview-77--ontrackdocumentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@lgr2002 lgr2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked the workflow changes and the CI build has passed. The PR updates the GitHub Actions versions, upgrades Node to v20, adds npm caching, and adds a build step. The change is focused only on the CI workflow file, so it looks safe to merge.

@Roeenk27
Copy link
Copy Markdown
Contributor

Roeenk27 commented May 6, 2026

Straightforward and necessary. Node v16 was EOL so this needed to happen. Build check in CI is a good addition. Clean diff, all checks pass, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants