ci: update node version and add build check#77
Open
jmirchh75 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for ontrackdocumentation ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lgr2002
approved these changes
Apr 27, 2026
lgr2002
left a comment
There was a problem hiding this comment.
Looks good. I checked the workflow changes and the CI build has passed. The PR updates the GitHub Actions versions, upgrades Node to v20, adds npm caching, and adds a build step. The change is focused only on the CI workflow file, so it looks safe to merge.
Contributor
|
Straightforward and necessary. Node v16 was EOL so this needed to happen. Build check in CI is a good addition. Clean diff, all checks pass, looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CI workflow to use newer GitHub Actions versions, and upgrades Node to v20 LTS. It also adds a build step so that CI verifies the Astro site builds successfully during pull requests.
The previous CI workflow configuration used an EOL version of Node (v16.14.2), therefore no longer receiving security updates. Updating to Node v20 improves overall security and stability.
Fixes: N/A
Type of change
How Has This Been Tested?
This was tested locally to ensure there were no issues. The following commands were run:
All commands completed successfully, resulting in the expected output.
Checklist