Addition of updater script#89
Open
kottochii wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the previous versions, the process of updating was in pulling the games repository from GitHub repository, with hopes that each game will have the executable for the given platform. However, this was not always the case. Also, it has been decided that it is better to not keep the compiled versions inside repository, but rather have then under releases.
This script (running of which is fully integrated in the intro screen) pulls the files from GitHub Releases (the latest available release), each time before the game runs instead of running it. There has also been added instruction on the use with a separate file
updater_readme.md.Known issues
Type of change
How Has This Been Tested?
When you run the update screen, the games should be pulling from the set repository for the platform that the machine is running on.
NOTE 1: Reviewers, as the current version of official
thoth-tech/arcade-gamesis lacking the releases section, you will have to test it with a repository, in which the games are present. I keepkottochii/thoth-arcade-gamesfor this purposes. In order to test run the script, you will have to make a change inupdater.py, and set variableGITHUB_REPOtokottochii/thoth-arcade-games(line 19 in the current revision).NOTE 2: Reviewers, there have been no other changes, so if you are attempting to test the work, you will have to ensure that your local machine could have made and run the
arcade-machinebefore these changes.Testing Checklist
Checklist
using namespace std::string_literalsis used locally, which does not confict with advice inCONTRIBUTING.md