Skip to content

Addition of updater script#89

Open
kottochii wants to merge 4 commits into
thoth-tech:mainfrom
kottochii:updater
Open

Addition of updater script#89
kottochii wants to merge 4 commits into
thoth-tech:mainfrom
kottochii:updater

Conversation

@kottochii
Copy link
Copy Markdown

Description

In the previous versions, the process of updating was in pulling the games repository from GitHub repository, with hopes that each game will have the executable for the given platform. However, this was not always the case. Also, it has been decided that it is better to not keep the compiled versions inside repository, but rather have then under releases.

This script (running of which is fully integrated in the intro screen) pulls the files from GitHub Releases (the latest available release), each time before the game runs instead of running it. There has also been added instruction on the use with a separate file updater_readme.md.

Known issues

  • Updater finds the architecture from the system only. It is not possible to request any particular architecture with command line.
  • In case of connection failing mid-way (i.e. after it has been first established), updater will still delete the old game directory (per game).

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation - new file

How Has This Been Tested?

When you run the update screen, the games should be pulling from the set repository for the platform that the machine is running on.

NOTE 1: Reviewers, as the current version of official thoth-tech/arcade-games is lacking the releases section, you will have to test it with a repository, in which the games are present. I keep kottochii/thoth-arcade-games for this purposes. In order to test run the script, you will have to make a change in updater.py, and set variable GITHUB_REPO to kottochii/thoth-arcade-games (line 19 in the current revision).

NOTE 2: Reviewers, there have been no other changes, so if you are attempting to test the work, you will have to ensure that your local machine could have made and run the arcade-machine before these changes.

Testing Checklist

  • Tested on Linux

Checklist

  • My code follows the style guidelines of this project
    • Note: using namespace std::string_literals is used locally, which does not confict with advice in CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from Arcade team on the Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant