remove dependency on Database.h, use sqlite3 C interface instead#87
Open
kottochii wants to merge 2 commits into
Open
remove dependency on Database.h, use sqlite3 C interface instead#87kottochii wants to merge 2 commits into
kottochii wants to merge 2 commits into
Conversation
|
A very easy way to make arcade machine live agian,but we need it indeed now,hope the next team can have a better solution,great,I approve this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From one of the old builds of SplashKit, the Database (and linkage to sqlite) class has been deleted. This change aims to remove the dependency on the functionality, and instead, use the sqlite API. The makefile will also attempt to link sqlite from default directory. If binaries are to be found in a non-standard location, the user will have to modify the makefile.
This change will not necessarily work for all Windows machines
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I made some local changes to ensure that the databases are actually queried (like ensuring that the user is rating the game at the end, and is able to see the new ratings).
Testing Checklist
Ubuntu 24.04.4 LTS)Checklist
If involving code
I have made corresponding changes to the documentationFolders and Files Added/Modified
Makefileinclude/Database.hinclude/GameData.hAdditional Notes
This change does not resolve any other issues, such as that the database functions are simply not used. In order to test the functionality of the changes, you will have to ensure that the program is attempting to use the database.
As the sqlite's C API is used, any pointer will be alive and in the memory until it is deleted (in this case, by the corresponding sqlite functions). Please double check that these functions are present for every exit point of the functions.