Addition of optional scaling and a callback on load completion#32
Open
adamsp wants to merge 8 commits into
Open
Addition of optional scaling and a callback on load completion#32adamsp wants to merge 8 commits into
adamsp wants to merge 8 commits into
Conversation
…or at instantiation and the ability to scale (or not) per image it loads
…se the scaleSize value was never being set.
…u supply a listener.
…urs, updated documentation, updated project properites back to original values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the option to specify a 'scale size' when you create the ImageLoader - I found that in some cases the default scale size was too small, especially when I was loading an image that I wanted the user to be able to pinch-zoom on.
I've also added a very basic callback, so that callers can be notified when the image has finished loading.
These changes should not break any existing code, as all the original method signatures are intact, with existing behaviour.