Skip to content

topology2: add rt721_l3_rt1320_l3 support#10708

Open
macchian wants to merge 1 commit intothesofproject:mainfrom
macchian:dev-rt721-rt1320-tplg
Open

topology2: add rt721_l3_rt1320_l3 support#10708
macchian wants to merge 1 commit intothesofproject:mainfrom
macchian:dev-rt721-rt1320-tplg

Conversation

@macchian
Copy link
Copy Markdown
Contributor

@macchian macchian commented Apr 17, 2026

Create the topology file of sof-ptl-rt721-l3-rt1320-l3 with PCH_DMIC 4-channel support when selecting the ACPI machine table.

@macchian macchian requested review from jsarha and ranj063 as code owners April 17, 2026 10:59
@macchian macchian mentioned this pull request Apr 17, 2026
Open
lgirdwood
lgirdwood approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @bardliao good fo you ?

@bardliao
Copy link
Copy Markdown
Collaborator

bardliao commented Apr 19, 2026

LGTM, @bardliao good fo you ?

The topology itself looks good to me. However, the upstream kernel will use function topology by default. We need to use the tplg_filename module parameter to specify the topology. Would it make more sense if we rename it to sof-ptl-rt721-l3-rt1320-l3-4ch-ssp8-bt as BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true?

@macchian
Copy link
Copy Markdown
Contributor Author

macchian commented Apr 20, 2026

LGTM, @bardliao good fo you ?

The topology itself looks good to me. However, the upstream kernel will use function topology by default. We need to use the tplg_filename module parameter to specify the topology. Would it make more sense if we rename it to sof-ptl-rt721-l3-rt1320-l3-4ch-ssp8-bt as BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true?

Yes, in this case we assign tplg_filename to target a specific topology. I expect the naming to be 'sof-ptl-rt721-l3-rt1320-l3-4ch-ssp2-bt', as you mentioned, correct?

@macchian macchian requested a review from bardliao April 20, 2026 05:31
@macchian
topology2: add rt721_l3_rt1320_l3 support
ac22a1e 
Create the topology file: sof-ptl-rt721-l3-rt1320-l3-4ch-ssp2-bt,
enabling BT on SSP2 and PCH_DMIC 4-channel support via the tplg_filename
parameter as a fallback when no ACPI machine table is found.

Signed-off-by: Mac Chiang <mac.chiang@intel.com>
@macchian macchian force-pushed the dev-rt721-rt1320-tplg branch from 07d2365 to ac22a1e Compare April 20, 2026 06:52
@macchian
Copy link
Copy Markdown
Contributor Author

macchian commented Apr 20, 2026

LGTM, @bardliao good fo you ?

The topology itself looks good to me. However, the upstream kernel will use function topology by default. We need to use the tplg_filename module parameter to specify the topology. Would it make more sense if we rename it to sof-ptl-rt721-l3-rt1320-l3-4ch-ssp8-bt as BT_PCM_ID=8,BT_ID=8,BT_PCM_NAME=Bluetooth,ADD_BT=true?

Yes, in this case we assign tplg_filename to target a specific topology. I expect the naming to be 'sof-ptl-rt721-l3-rt1320-l3-4ch-ssp2-bt', as you mentioned, correct?

@bardliao , done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bardliao bardliao bardliao approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@kv2019i kv2019i kv2019i approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@macchian @bardliao @lgirdwood @kv2019i