Skip to content

[Docker] Suggestion: support base path for selfhosting #352

Description

@sambartik

Hello, I think it would be really handy to support base path so that the css can be accessed behind reverse proxy with url: xxx.xxx.xxx.xxx/themepark.

Activity

  1. GilbN commented on Mar 29, 2022

    @GilbN
    Collaborator

    please test -e TP_URLBASE on the develop tag

  2. sambartik commented on Mar 29, 2022

    @sambartik
    ContributorAuthor

    Thanks, great work! Seems to be okay. However it is not yet implemented in docker mods for me and putting xxx.xxx.xxx.xxx/themepark url in TP_DOMAIN env variable resulted in sed errors.

  3. GilbN commented on Mar 29, 2022

    @GilbN
    Collaborator

    use TP_DOMAIN=domain.com\/themepark

  4. sambartik commented on Mar 29, 2022

    @sambartik
    ContributorAuthor

    Great, it works! Thanks!

  5. sambartik commented on Mar 29, 2022

    @sambartik
    ContributorAuthor

    I have just noticed that when accessing the base theme css files via web, they have an @import statements with url that has http scheme despite having TP_SCHEME=https env variable set up. When I cat the css file, those same urls had https scheme, but they were missing the base path.

    So: when acessing

    • Via web: @import url("http://xxx.xxx.xxx.xxx/themepark/css/base/bazarr/bazarr-base.css?sha=None");
    • Directly the css file located in /config/www/css folder: @import url("https://xxx.xxx.xxx.xxx/css/base/bazarr/bazarr-base.css?sha=None");
  6. GilbN commented on Mar 29, 2022

    @GilbN
    Collaborator

    make sure you reverse proxy the https port or access locally using the https port

  7. sambartik commented on Mar 30, 2022

    @sambartik
    ContributorAuthor

    Yup, I was connecting to theme-park via http from the reverse proxy point of view. Nonetheless, it seems kind of strange. I would think that the scheme depended entirely on what I set in the env variable. Is this the intended behaviour?

  8. locked and limited conversation to collaborators on Mar 30, 2022
  9. converted this issue into a discussion #353 on Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions