Repository navigation
Lightning methods and portable configs - #167
Closed
selmanozleyen wants to merge 46 commits into
Closed
selmanozleyen wants to merge 46 commits into
selmanozleyen wants to merge 46 commits into
Conversation
# Conflicts: # src/sckitflow/_model.py # src/sckitflow/core/_data_utils.py # src/sckitflow/core/methods/_base.py # tests/core/methods/library/test_cfm.py # tests/core/methods/test_custom.py # tests/core/methods/test_methods.py # tests/test_model.py
Replace the hand-rolled training stack with lightning.pytorch and cut the abstraction layers around it. - delete Trainer, TrainingCallbacks, WandBLogger, OptimConfig, OptimizationManager; add TrainingPlan (LightningModule) and FlowDataModule (LightningDataModule), whose state_dict carries the schema inside the Lightning checkpoint - Model takes prebuilt methods and a data module; no module/protocol building, no registries, no *_cls/_id/_kwargs, no ModelKwargs - collapse ProtocolSpecs/FlowSpecs/_SpecsHolder and the Abstract*/ wrapper hierarchies: two Protocols plus AbstractMethod/AbstractFlowMethod - rename protocol -> method throughout; drop BaseModule for nn.Module - methods no longer take dtype/device_id and no longer move the module they are given; the batch is the reference, and the loader builds it in the module's dtype
# Conflicts: # tests/test_model.py # tests/trainer/test_trainer.py
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ators # Conflicts: # src/sckitflow/_model.py # src/sckitflow/_types.py # src/sckitflow/core/_data_utils.py # src/sckitflow/core/_types.py # src/sckitflow/core/methods/_base.py # src/sckitflow/core/methods/library/_cfm.py # src/sckitflow/core/nn/_modules.py # src/sckitflow/core/nn/_vf.py # src/sckitflow/trainer/_callbacks.py # tests/core/methods/library/test_cfm.py # tests/core/methods/test_custom.py # tests/core/methods/test_methods.py # tests/test_model.py
This was referenced Sep 29, 2026
selmanozleyen
force-pushed
the
refactor/methods
branch
from
October 2, 2026 12:44
1cad43f to
8486d56
Compare
Collaborator
Author
|
closed in favor of #170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
refactor/methods.TrainingPlan(LightningModule) andFlowDataModule(LightningDataModule).Modelis removed.scfit.registry:CFMConfig,ODEConfig,FlowDataConfig, path and splitter configs.save_run/load_runwritespecs.jsonplusweights.pt, with nothing pickled.rng).Draft:
test_base,test_opt,test_model,test_callbacksandtest_trainerstill use names this removes.