Changed Method design - #163
Open
lorenzo-consoli wants to merge 16 commits into
Open
lorenzo-consoli wants to merge 16 commits into
lorenzo-consoli wants to merge 16 commits into
Conversation
selmanozleyen
added this pull request to stack #165
September 21, 2026 12:24
selmanozleyen
force-pushed
the
refactor/type-names
branch
from
September 28, 2026 12:25
b7134ca to
9c44f8b
Compare
selmanozleyen
removed this pull request from stack #165
September 28, 2026 12:56
selmanozleyen
force-pushed
the
refactor/methods
branch
from
October 2, 2026 12:44
1cad43f to
8486d56
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abandoned the design with
BaseMethodandGenerativeFlowin favor of a more flexible, protocol-based, approach.The
core.methods._basewas restructured significantly. The main objects there are the following:SupportsProtocol,SupportsTraining,SupportsInference: Protocols that define the structural behavior of the protocols.ProtocolSpecsandFlowSpecsare used to hold the specification for general and flow-based protocols.compute_loss,predictandmatchingprotocols.match_fnbeforecompute_loss)The
core.methods.libraryis then structured in two subfolderscore.methods.trainingandcore.methods.inference. I implemented theCFMTrainingProtocoland theODEInferencein the respective folders.Now the
Modelclass will be instantiated using amodule, atraining_protocoland aninference_protocol. They have to be set at initialization, but can be overridden at call-time.