Repository navigation
Conversation
Member
|
Can one of the admins verify this patch? |
Member
|
Hi @jakduch thanks the for the PR, in the end we discovered that pulp dropped the need of rhsm and it's now used w/o the need of rhsm python package, but this is a good support to have. |
Odilhao
reviewed
Sep 28, 2026
jakduch
force-pushed
the
fix/3126-preserved-requires
branch
2 times, most recently
from
September 30, 2026 11:46
1fbb07b to
05084c6
Compare
Contributor
Author
|
The RPM job correctly caught that the modified spec kept the old release. I bumped it to |
jakduch
force-pushed
the
fix/3126-preserved-requires
branch
from
September 30, 2026 13:41
05084c6 to
23ce198
Compare
jakduch
force-pushed
the
fix/3126-preserved-requires
branch
from
October 2, 2026 13:55
23ce198 to
f418b18
Compare
Contributor
Author
|
Thanks. I rebased this onto the current rpm/develop and removed the python-rhsm spec change since Pulpcore no longer needs it. The PR now contains only the generic marker support and its regression tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# update-deps: preserve-requiremarker for manual RPM requirementsTesting
python -m pytest automation/tests/ -v— 30 passedpython -m py_compile automation/update_deps.py automation/dep_diff.pyFixes #3126
This contribution was prepared with AI assistance and manually reviewed and tested.