Skip to content

Changed dropdown from disabled to hidden#1260

Merged
jackrhoa merged 1 commit into
devfrom
1258-no-suggested-courses
Jul 10, 2026
Merged

Changed dropdown from disabled to hidden#1260
jackrhoa merged 1 commit into
devfrom
1258-no-suggested-courses

Conversation

@Adrian-E-V

@Adrian-E-V Adrian-E-V commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

GitHub Issues addressed

What I did

  • Changed the dropdown to hidden instead of disabled
  • Dropdown now reappears if users wish to change their course selection in reviews

Screenshots

  • Before
image
  • After
image

Summary by CodeRabbit

  • Bug Fixes
    • Improved the review form so autocomplete dropdowns reliably hide after selection.

@Adrian-E-V Adrian-E-V self-assigned this Jul 5, 2026
@Adrian-E-V Adrian-E-V linked an issue Jul 5, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 307251c9-bd98-4abb-b070-d4994eb164c3

📥 Commits

Reviewing files that changed from the base of the PR and between ed955fb and e6fe9aa.

📒 Files selected for processing (1)
  • tcf_website/static/js/site/review/review_cascade.js

📝 Walkthrough

Walkthrough

The review form cascade click handler now hides the autocomplete dropdown container by setting dd.hidden = true instead of dd.style.display = "none", applied identically for both course and club selection.

Changes

Dropdown Hide Method Update

Layer / File(s) Summary
Update dropdown hide mechanism
tcf_website/static/js/site/review/review_cascade.js
Both course and club selection handlers switch from setting dd.style.display = "none" to dd.hidden = true to hide the autocomplete dropdown container.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and reflects the dropdown visibility change in the review form.
Description check ✅ Passed The description covers the issue, the change, and screenshots, but it omits testing and notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1258-no-suggested-courses

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Adrian-E-V Adrian-E-V requested a review from jackrhoa July 9, 2026 02:17
@jackrhoa jackrhoa merged commit 6d1ede4 into dev Jul 10, 2026
6 checks passed
@jackrhoa jackrhoa deleted the 1258-no-suggested-courses branch July 10, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: No suggested course list when editing selected course

2 participants