Clean tests - #32
Open
StrongestNumber9 wants to merge 4 commits into
Open
Clean tests#32StrongestNumber9 wants to merge 4 commits into
StrongestNumber9 wants to merge 4 commits into
Conversation
Tiihott
requested changes
Jun 5, 2026
Tiihott
left a comment
Tiihott
left a comment
Contributor
There was a problem hiding this comment.
There is an error in pcre2_matchall_clrf_test() assertions.
| @@ -748,19 +635,19 @@ else if (s1.get_utf8()){ /* Otherwise, ensure we */ | |||
| Assertions.assertEquals("43434.com", it.getValue()); | |||
Contributor
There was a problem hiding this comment.
Expected value should be "example.com"
kortemik
reviewed
Jun 5, 2026
|
|
||
| /*This is the test module for testing the pcre-regex library from Java. | ||
| * The functions called here will represent the functions that are available to use in the aforementioned library.*/ | ||
| public class Main { |
Member
There was a problem hiding this comment.
Is there a readme or usage instructions that covers all the cases used here?
kortemik
reviewed
Jun 5, 2026
|
|
||
| @Test | ||
| void pcre2_translator_test() { | ||
| // broken |
Member
There was a problem hiding this comment.
is this a case that does not work within the code? if so add Disabled annotation with a reason and an issue to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #29 but couple of tests still needs to be cleaned up.
Removes Main.java, updates junit version, cleans up tests to be more reliable and easier to read & verify