Split charge response errors by MPP failure layer#511
Draft
betterclever wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #453.
PaymentErrorvariants for non-402 charge response failures after credential submission402responses classified asPaymentRejected, matching MPP semantics for failed payment credential validationWhy
tempo-requestpreviously mapped every charge response withstatus_code >= 400toPaymentRejected. MPP uses402for payment-required and payment credential validation failures. Other 4xx/5xx responses after credential submission are not necessarily payment rejections; they are response-layer failures from the protected resource/server.This keeps payment failures distinct from application/server failures while avoiding any claim that non-2xx responses imply successful settlement.
Tests
cargo fmtcargo test -p tempo-request payment::charge::tests::test_parse_payment_rejection -- --nocapturecargo test -p tempo-common test_upstream -- --nocapturecargo test -p tempo-common -p tempo-requestcargo check --workspace