Skip to content

fix: accept no-browser wallet flows#27

Merged
brendanjryan merged 1 commit into
mainfrom
brendanjryan/fix-login-no-browser
Jun 23, 2026
Merged

fix: accept no-browser wallet flows#27
brendanjryan merged 1 commit into
mainfrom
brendanjryan/fix-login-no-browser

Conversation

@brendanjryan

Copy link
Copy Markdown
Contributor

Summary

  • Change login and fund browser options to use incur's positive boolean option shape
  • Preserve --no-browser behavior via boolean negation parsing
  • Add parser regression coverage for login and fund no-browser flows

Motivation

incur treats --no-* flags as boolean negation. Defining a literal no-browser option caused tempo wallet login --no-browser to fail with an unknown flag even though the command help and docs referenced that flow.

Key design considerations

  • Uses browser: true as the schema default so --no-browser parses to browser: false
  • Applies the same fix to fund, which used the same option shape
  • Keeps help text explicit that --no-browser disables browser opening

@brendanjryan brendanjryan marked this pull request as ready for review June 23, 2026 22:49
@brendanjryan brendanjryan force-pushed the brendanjryan/fix-login-no-browser branch from 7a78eb1 to 5e21048 Compare June 23, 2026 22:49
@brendanjryan brendanjryan merged commit e83694e into main Jun 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant