Add Standalone Activities support to Temporal Nexus Operation Handler#748
Open
Quinn-With-Two-Ns wants to merge 3 commits into
Open
Add Standalone Activities support to Temporal Nexus Operation Handler#748Quinn-With-Two-Ns wants to merge 3 commits into
Quinn-With-Two-Ns wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f807fc513
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3f807fc to
84020ad
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
Reviewed by Cursor Bugbot for commit 84020ad. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What was changed
Add Standalone Activities support to Temporal Nexus Operation Handler
Why?
Allow calling Standalone Activities as a Nexus Operation
Checklist
Closes
How was this tested:
Note
Medium Risk
Touches experimental Nexus operation lifecycle (async tokens, callbacks, cancel routing) and standalone activity RPC fields; behavior is covered by new unit and worker integration tests but spans client and handler paths.
Overview
Adds standalone activity backing for experimental Temporal Nexus
TemporalOperationHandler, so handlers can return an async activity-execution operation token (typet=2) instead of only workflow-run tokens.ITemporalNexusClientgainsStartActivityAsyncoverloads (expression and by name) that schedule activities viaNexusActivityStartHelper: default task queue from the operation, deterministic activity Id, Nexus request ID, inbound links, completion callbacks withNexus-Operation-Token, andUseExistingon-conflict attach options.StartActivityOptionspicks up internal links, callbacks, on-conflict, and request ID wired throughStartActivityExecution.Cancel on
TemporalOperationHandlerpeeks token type withLoadTokenType, then cancels the workflow or standalone activity (overridableCancelActivityExecutionAsync). Activity and workflow proto ↔ Nexus link conversion is extended; workflow/activity starts from Nexus now add outbound links from the server response (workflow falls back to a synthetic started-event link). Shared start plumbing moves toNexusOperationStartCommon; workflow start docs note TaskQueue can default to the operation queue.Reviewed by Cursor Bugbot for commit 84020ad. Bugbot is set up for automated code reviews on this repo. Configure here.